Discussion:
[PATCH] REGTEST/MINOR: skip seamless-reload test with abns socket on freebsd
PiBa-NL
2018-12-08 20:01:32 UTC
Permalink
Hi List, Willy,

Added below to the reg-tests/seamless-reload/b00000.vtc, I'm sure there
are other targets to be excluded, but I'm not sure which. Or should i
have listed 'all' targets except the 5 linux22 - linux2628 specific
versions to be excluded? Only thing I know for sure it doesn't work on
FreeBSD currently.. I can re-spin the patch with all non-linux targets
listed if desired.

# expose-fd is available starting at version 1.8
#REQUIRE_VERSION=1.8
# abns@ sockets are not available on freebsd
#EXCLUDE_TARGETS=freebsd

Regards,
PiBa-NL (Pieter)
Willy Tarreau
2018-12-08 21:03:07 UTC
Permalink
Hi Pieter,
Post by PiBa-NL
Hi List, Willy,
Added below to the reg-tests/seamless-reload/b00000.vtc, I'm sure there are
other targets to be excluded, but I'm not sure which. Or should i have
listed 'all' targets except the 5 linux22 - linux2628 specific versions to
be excluded? Only thing I know for sure it doesn't work on FreeBSD
currently.. I can re-spin the patch with all non-linux targets listed if
desired.
# expose-fd is available starting at version 1.8
#REQUIRE_VERSION=1.8
#EXCLUDE_TARGETS=freebsd
Thank you, that looks fine like this. Don't worry too much about
excluding targets you don't know. Few people will use these tests
anyway, they are mostly for developers and contributors. It's not
as if many of the other systems were used for development ;-) So
in the end if anyone faces issues, they'll quickly figure how to
blacklist their target and will submit an updated patch.

Thanks!
Willy

Loading...