[PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

[Joseph Herlant]

Hi,

The attached patch fixes typos in the code comments of the proto_tcp subsystem.

Thanks,
Joseph

[Joseph Herlant]

Sorry, I forgot the attachement on this one.

Post by Joseph Herlant
Hi,
The attached patch fixes typos in the code comments of the proto_tcp subsystem.
Thanks,
Joseph

[Joseph Herlant]

Will do, thanks!
On Sun, Nov 25, 2018 at 12:10 PM William Lallemand

Post by Joseph Herlant
Sorry, I forgot the attachement on this one.

Hi Joseph,
I recommand you to use git send-email to avoid that, it can send a whole patch
series in a unique mail thread, and it's easier for us to apply a patch which
is not an attachment :-)
Regards,
--
William Lallemand

[Willy Tarreau]

Hi Joseph,

Post by Joseph Herlant
Will do, thanks!
On Sun, Nov 25, 2018 at 12:10 PM William Lallemand

Post by Joseph Herlant
Sorry, I forgot the attachement on this one.

Hi Joseph,
I recommand you to use git send-email to avoid that, it can send a whole patch
series in a unique mail thread, and it's easier for us to apply a patch which
is not an attachment :-)

I've applied your whole series, thanks.

I second William in the use of "git send-email" to send series. It's a
very convenient and powerful tool. It works exactly like git-am except
that instead of just making a series of patches, it can send them all.
So in a single command you can send all your patches at once. It will
make a whole thread of them, making it easier to pick them in the right
order. You can even include a cover letter where you present what you
intend to address with the series (e.g. "this series fixes misleading
comments in the code"). It still allows reviewers to respond and amend
them. Then I can trivially pick the whole thread, remove or edit the
patches that require minor adjustments and apply everything at once.

Thanks,
Willy

[Valentin Vidic]

-/* Returns some tcp_info data is its avalaible. "dir" must be set to 0 if
- * the client connection is require, otherwise it is set to 1. "val" represents
+/* Returns some tcp_info data is its available. "dir" must be set to 0 if
+ * the client connection is required, otherwise it is set to 1. "val" represents

Should this sentence read:

Returns some tcp_info data if it's available.

[Joseph Herlant]

On Sun, Nov 25, 2018 at 12:47 PM Valentin Vidic

Post by Valentin Vidic
Returns some tcp_info data if it's available.

Indeed, good catch, thanks, I will update the patch.
Thanks,
Joseph

[Joseph Herlant]

Fixes typos in the code comments of the proto_tcp subsystem.
---
src/proto_tcp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/proto_tcp.c b/src/proto_tcp.c
index c7951c55..6f2683c5 100644
--- a/src/proto_tcp.c
+++ b/src/proto_tcp.c
@@ -1534,11 +1534,11 @@ smp_fetch_dport(const struct arg *args, struct sample *smp, const char *kw, void

#ifdef TCP_INFO

-/* Returns some tcp_info data is its avalaible. "dir" must be set to 0 if
- * the client connection is require, otherwise it is set to 1. "val" represents
+/* Returns some tcp_info data if it's available. "dir" must be set to 0 if
+ * the client connection is required, otherwise it is set to 1. "val" represents
* the required value. Use 0 for rtt and 1 for rttavg. "unit" is the expected unit
* by default, the rtt is in us. Id "unit" is set to 0, the unit is us, if it is
- * set to 1, the untis are milliseconds.
+ * set to 1, the units are milliseconds.
* If the function fails it returns 0, otherwise it returns 1 and "result" is filled.
*/
static inline int get_tcp_info(const struct arg *args, struct sample *smp,