Discussion:
PATCH : mux_h2 h2c pointer deref
Mildis
2018-09-23 16:18:37 UTC
Permalink
Hi,

Here is a patch for a null-deref.
It checks if h2c exists before working on it.
Willy Tarreau
2018-10-02 02:23:43 UTC
Permalink
Hi,
Post by Mildis
Hi,
Here is a patch for a null-deref.
It checks if h2c exists before working on it.
For these two patches, I'd prefer to have multiple exit labels
than adding some "if" in the error exit path. It's important that
the error path is clear, linear and without any ambiguity. For
example, just add labels likes "fail_no_h2c" and "fail_no_queue"
pointing to the return. That easily allows to later add intermediary
branches if some other entries are allocated.

Willy
Mildis
2018-10-02 14:52:46 UTC
Permalink
OK.
Here you are.
Willy Tarreau
2018-10-11 13:19:28 UTC
Permalink
Post by Mildis
OK.
Here you are.
Applied, thanks!
Willy

PS: sorry for the delay, it was left rotting too far away in my mailbox!
Loading...